Revise some character table tests to use a doctest #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBreuer
approved these changes
Sep 19, 2023
lgoettgens
reviewed
Sep 19, 2023
These tests deal with testing how character tables are printed
in various situations. We change this to (ab)use the `jldoctest`
system from Documenter. This brings with it the advantage that it
is very easy to adjust the tests for desired changes to the printing:
it can be done changing
doctest(nothing, [AuxDocTest_GroupCharacters])
to
doctest(nothing, [AuxDocTest_GroupCharacters]; fix=true)
and then running this in the Julia REPL:
include("test/Groups/group_characters.jl")
fingolfin
force-pushed
the
mh/doctest-for-character-tables
branch
from
78dbf63 to
492f8fe
Compare
|
@ThomasBreuer exactly |
|
@ThomasBreuer wrote:
Which one is that? I am aware of |
Merged
|
fieker
pushed a commit
that referenced
this pull request
Sep 29, 2023
These tests deal with testing how character tables are printed
in various situations. We change this to (ab)use the `jldoctest`
system from Documenter. This brings with it the advantage that it
is very easy to adjust the tests for desired changes to the printing:
it can be done changing
doctest(nothing, [AuxDocTest_GroupCharacters])
to
doctest(nothing, [AuxDocTest_GroupCharacters]; fix=true)
and then running this in the Julia REPL:
include("test/Groups/group_characters.jl")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests deal with testing how character tables are printed in various situations. We change this to (ab)use the
jldoctestsystem from Documenter. This brings with it the advantage that it is very easy to adjust the tests for desired changes to the printing: it can be done changingto
and then running this in the Julia REPL:
This PR is motived by PR #2774 where it helps me to adjust the tests for the revised printing. But I think it's also of independent benefit.