Resolve some JET warnings #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... about captured variables and runtime dispatch
thofma
reviewed
Sep 18, 2023
| @@ -57,15 +56,15 @@ function _mod_p_to_a_kernel(G::Union{zzModMatrix, ZZModMatrix}, a, p) | |||
| end | |||
| end | |||
| for h in gensk | |||
| g = deepcopy(E) | |||
| g = identity_matrix(R, n) | |||
There was a problem hiding this comment.
Whats the problem with this one?
There was a problem hiding this comment.
In at least one of the functions, it redefined E to different things, and these objects are then captured in closures; it is not happy that E is redefined then. It seemed simplest to just replace all those deepcopy calls by direct calls to identity_matrix (IMHO makes it easier to read).
fieker
pushed a commit
that referenced
this pull request
Sep 29, 2023
... about captured variables and runtime dispatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... about captured variables and runtime dispatch
Just the tip of the iceberg, but I figured I should already submit this, as I don't know when/if I'll be able to work through all the output produced by JET....
@fieker this touches some of your code, too