twisted modules #2807
twisted modules #2807
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2807 +/- ##
=======================================
Coverage 73.63% 73.63%
=======================================
Files 455 455
Lines 64536 64566 +30
=======================================
+ Hits 47520 47543 +23
- Misses 17016 17023 +7
|
|
|
||
| function twist(M::SubquoModule{T}, g::GrpAbFinGenElem) where {T<:MPolyDecRingElem} | ||
| R = base_ring(M) | ||
| @req parent(g) == grading_group(R) "Group element not contained in grading group of base ring" |
There was a problem hiding this comment.
Is == here enough or do we need ===? (same at other places)
There was a problem hiding this comment.
@fieker Please clearify!
There was a problem hiding this comment.
Sideremark:
If === is needed, this problem is not restricted to this PR. The problem then also occurs in Modules/ModulesGraded.jl (and possibly other files) as the same kind of comparison also occurs there with ==.
There was a problem hiding this comment.
I think == and === are the same for rings, so either is fine.
There was a problem hiding this comment.
As confirmed by @fieker, it is as I thought: There is no difference between == and === here. That is, the PR can be merged and no other action is needed.
Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Lars Göttgens <[email protected]>
|
Thanks for spotting, it should be |
| ``` | ||
| """ | ||
| function twist(M::ModuleFP{T}, g::GrpAbFinGenElem) where {T<:MPolyDecRingElem} | ||
| error("Not implemented for the given type") |
There was a problem hiding this comment.
I am not going to block this PR over this, but, normally we strive to indent code with (at least) two spaces.
(But of course we are already widely inconsistent about this, which is why I am not asking for it to be changed here and now, just wanted to point it out)
No description provided.