-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move test_save_load_roundtrip
to init file
#2801
Conversation
106c2ef
to
f99b09d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I would just like to see if we can put the init file one level deeper and then merge
An alternative would be to add a conditional include to the relevant test files: isdefined(Main, :test_save_load_roundtrip) || include(joinpath(Oscar.oscardir,"test","Serialization","init_tests.jl")) This would allow running the tests separately from the main runtests without manually including that file. |
That seems like a better idea. I will change this pr accordingly. |
Codecov Report
@@ Coverage Diff @@
## master #2801 +/- ##
==========================================
+ Coverage 73.61% 73.62% +0.01%
==========================================
Files 455 455
Lines 64469 64514 +45
==========================================
+ Hits 47459 47501 +42
- Misses 17010 17013 +3
|
When running the tests with multiple workers, the
FTheoryTools
andQuadFormAndIso
tests may fail, when they are run on a different worker than the serialization tests. This is due to the latter adding a test functiontest_save_load_roundtrip
that is used by the former two.My solution is to move the
test_save_load_roundtrip
function to a file that gets included@everywhere
right before running any tests. When similar things come up in the future, we may put them there as well.The name of the file is open for discussion.