Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automorphism_group fix for rank 0 matroids + added test #2799

Merged

Conversation

Sequenzer
Copy link
Collaborator

Rank zero matroids would cause an error, which has been fixed by this.

@Sequenzer Sequenzer marked this pull request as ready for review September 14, 2023 16:25
@benlorenz benlorenz marked this pull request as draft September 14, 2023 18:51
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #2799 (b498655) into master (ebee98c) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2799      +/-   ##
==========================================
- Coverage   73.61%   73.60%   -0.01%     
==========================================
  Files         455      455              
  Lines       64469    64471       +2     
==========================================
- Hits        47459    47455       -4     
- Misses      17010    17016       +6     
Files Changed Coverage
src/Combinatorics/Matroids/matroids.jl 100.00%

@Sequenzer Sequenzer marked this pull request as ready for review September 18, 2023 11:29
@antonydellavecchia antonydellavecchia enabled auto-merge (squash) September 18, 2023 11:38
@antonydellavecchia antonydellavecchia merged commit 4e7fe12 into oscar-system:master Sep 18, 2023
10 of 12 checks passed
fieker pushed a commit that referenced this pull request Sep 29, 2023
* automorphism_group fix for rank 0 matroids + added test

* Update src/Combinatorics/Matroids/matroids.jl

Co-authored-by: Lars Göttgens <[email protected]>

* fixed loop bug and added test

* Update src/Combinatorics/Matroids/matroids.jl

---------

Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Benjamin Lorenz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants