-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toric morphisms to morphisms of covered schemes #2779
Toric morphisms to morphisms of covered schemes #2779
Conversation
70a911d
to
3a6c056
Compare
Rebased just now, since #2741 has been merged. |
Looks like we should override the print method for toric morphisms once again. For now it seems to default to the one for morphisms of covered schemes which entails actually computing the whole thing. We definitely want to avoid that. |
3a6c056
to
96d4f56
Compare
Just rebased to the latest master. |
96d4f56
to
b2bf093
Compare
Codecov Report
@@ Coverage Diff @@
## master #2779 +/- ##
==========================================
- Coverage 73.63% 73.58% -0.05%
==========================================
Files 455 455
Lines 64411 64481 +70
==========================================
+ Hits 47427 47448 +21
- Misses 16984 17033 +49 |
Based on conversations with @HechtiDerLachs, this is ready for review. As the title says, this PR allows to convert a toric morphism to a morphism of (covered) schemes. In this regard, this PR is again at the interface between toric geometry and algebraic geometry. Hence, it seems reasonable to bring expertise from both areas to check on this PR. Let me thus call in @lkastner @simonbrandhorst - what do you think of this PR? (The upshot of all this is to enable blowup functionality, including proper/strict transforms in the toric setting and then to make use of these tools in the context of the FTheoryTools. I am sure @apturner will be very happy with the changes in this PR and the next couple that @HechtiDerLachs and I are working on/discussing.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking forward to this! Well done.
Continuation of #2741 . To be rebased eventually.