Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toric morphisms to morphisms of covered schemes #2779

Conversation

HechtiDerLachs
Copy link
Collaborator

Continuation of #2741 . To be rebased eventually.

@HechtiDerLachs HechtiDerLachs marked this pull request as draft September 7, 2023 11:15
@HereAround HereAround force-pushed the toric_morphisms_to_morphisms_of_covered_schemes branch from 70a911d to 3a6c056 Compare September 8, 2023 09:25
@HereAround
Copy link
Member

Rebased just now, since #2741 has been merged.

@HechtiDerLachs
Copy link
Collaborator Author

Looks like we should override the print method for toric morphisms once again. For now it seems to default to the one for morphisms of covered schemes which entails actually computing the whole thing. We definitely want to avoid that.

@HereAround HereAround force-pushed the toric_morphisms_to_morphisms_of_covered_schemes branch from 3a6c056 to 96d4f56 Compare September 13, 2023 09:00
@HereAround
Copy link
Member

Continuation of #2741 . To be rebased eventually.

Just rebased to the latest master.

@HereAround HereAround force-pushed the toric_morphisms_to_morphisms_of_covered_schemes branch from 96d4f56 to b2bf093 Compare September 13, 2023 09:16
@HereAround HereAround marked this pull request as ready for review September 13, 2023 09:19
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #2779 (b2bf093) into master (79874fd) will decrease coverage by 0.05%.
Report is 7 commits behind head on master.
The diff coverage is 68.28%.

@@            Coverage Diff             @@
##           master    #2779      +/-   ##
==========================================
- Coverage   73.63%   73.58%   -0.05%     
==========================================
  Files         455      455              
  Lines       64411    64481      +70     
==========================================
+ Hits        47427    47448      +21     
- Misses      16984    17033      +49     
Files Changed Coverage
experimental/JuLie/src/schur_polynomials.jl ø
...ntal/QuadFormAndIsom/src/lattices_with_isometry.jl ø
experimental/Schemes/CoveredProjectiveSchemes.jl ø
src/AlgebraicGeometry/Schemes/Glueing/Methods.jl ø
...eometry/Schemes/ProjectiveSchemes/Objects/Types.jl ø
src/Modules/FreeModules-graded.jl 0.00%
src/Modules/ModulesGraded.jl 0.00%
src/Rings/mpoly-affine-algebras.jl 0.00%
src/Rings/mpoly-graded.jl 0.00%
src/Rings/mpolyquo-localizations.jl ø
... and 14 more

@HereAround
Copy link
Member

Based on conversations with @HechtiDerLachs, this is ready for review. As the title says, this PR allows to convert a toric morphism to a morphism of (covered) schemes. In this regard, this PR is again at the interface between toric geometry and algebraic geometry. Hence, it seems reasonable to bring expertise from both areas to check on this PR. Let me thus call in @lkastner @simonbrandhorst - what do you think of this PR?

(The upshot of all this is to enable blowup functionality, including proper/strict transforms in the toric setting and then to make use of these tools in the context of the FTheoryTools. I am sure @apturner will be very happy with the changes in this PR and the next couple that @HechtiDerLachs and I are working on/discussing.)

Copy link
Collaborator

@simonbrandhorst simonbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking forward to this! Well done.

@fingolfin fingolfin merged commit d3a975a into oscar-system:master Sep 18, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants