-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduction mod p for schemes #2387
Reduction mod p for schemes #2387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this goes in the right direction.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2387 +/- ##
==========================================
+ Coverage 71.44% 71.55% +0.11%
==========================================
Files 384 385 +1
Lines 52652 52798 +146
==========================================
+ Hits 37615 37780 +165
+ Misses 15037 15018 -19
|
This should be ready to go as a first version from my side. Let's see if the tests go through. Then I'll take care of switching off some internal tests and eventually rename everything to |
f1919ba
to
19c9180
Compare
######################################################################## | ||
# Base change | ||
######################################################################## | ||
struct BaseChangeGlueingData{T1, T2} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
struct BaseChangeGlueingData{T1, T2} | |
struct BaseChangeGlueingData{T1, T2} # used for LazyGlueing |
Could you please also add a test when one works over a non-trivial base and restricts to a fiber, i.e. |
I probably could. However, our schemes are not really equipped with a backend to handle these kind of relative schemes. I don't think that translating something like Edit: I could try to do something with my |
@simonbrandhorst : Have a look at the test file, please. Do you think this goes in the right direction? If yes, I will extend to
CoveredScheme
s.