fixed the leading zero bug in matroid_hex (#4299)

oscar-system · Nov 12, 2024 · 2d7a2b0 · 2d7a2b0
1 parent b3ab222
commit 2d7a2b0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/Combinatorics/Matroids/properties.jl b/src/Combinatorics/Matroids/properties.jl
@@ -1059,11 +1059,9 @@ julia> matroid_hex(fano_matroid())
 function matroid_hex(M::Matroid)
   rvlx = min_revlex_basis_encoding(M)
   r,n = rank(M), length(M) 
+  v = zeros(Int, 4*ceil(Int, length(rvlx)/4))
+  v[length(v)-length(rvlx)+1:end] = _revlex_basis_to_vector(rvlx)
 
-  v = _revlex_basis_to_vector(rvlx)
-  for _ in 1:(4-length(v)%4)
-    pushfirst!(v,0)
-  end
   v = reshape(v,4,:)
   v = [string(parse(Int, join(v[:, j]), base=2), base=16) for j in 1:size(v)[2]]
 

diff --git a/test/Combinatorics/Matroids/Matroids.jl b/test/Combinatorics/Matroids/Matroids.jl
@@ -422,10 +422,17 @@
   @testset "matroid_hex" begin
     M = fano_matroid() 
     N = uniform_matroid(2, 4)
+    NN = uniform_matroid(1, 4)
 
     M1 = matroid_from_matroid_hex(matroid_hex(M)) 
     N1 = matroid_from_matroid_hex(matroid_hex(N))
+    NN1 = matroid_from_matroid_hex(matroid_hex(NN))
+
     @test is_isomorphic(M, M1)
     @test is_isomorphic(N, N1)
+
+    @test matroid_hex(NN) == "r1n4_f"
+    @test is_isomorphic(NN, NN1)
+
   end
 end