-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: release info in docs #1794
Conversation
Signed-off-by: Lou DeGenaro <[email protected]>
Fixes #1793 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment
``` | ||
trestle 3.x => OSCAL 1.1.2 | ||
trestle 2.x => OSCAL 1.0.4 | ||
trestle 1.x => OSCAL 1.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also add
trestle 0.37.x => OSCAL 1.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@@ -148,7 +148,7 @@ This command will return the current version of Trestle and OSCAL it is using. | |||
|
|||
Running `trestle version` will return: | |||
|
|||
> Trestle version v2.0.0 based on OSCAL version 1.0.4 | |||
> Trestle version v3.6.0 based on OSCAL version 1.1.2 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we say Trestle version v3.x.x based on OSCAL version 1.1.2
else with every release we will also have to necessarily update this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Signed-off-by: Lou DeGenaro <[email protected]>
Signed-off-by: Lou DeGenaro <[email protected]>
…pass/compliance-trestle.git into fix/docs-oscal-version
docs/index.md
Outdated
@@ -44,7 +44,7 @@ Below shows trestle versions correspondence with OSCAL versions: | |||
trestle 3.x => OSCAL 1.1.2 | |||
trestle 2.x => OSCAL 1.0.4 | |||
trestle 1.x => OSCAL 1.0.2 | |||
trestle 0.x => OSCAL 1.0.0 | |||
trestle 0.3.7 => OSCAL 1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is trestle 0.37.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Fixed.
Signed-off-by: Lou DeGenaro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Types of changes
develop
->main
)Quality assurance (all should be covered).
Summary
Key links:
Before you merge