osbuild: ensure /var/tmp is a real directory #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
previously approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Thanks! Let's get @henrywang to test this on his issue before merging?
ondrejbudai
previously approved these changes
Mar 20, 2024
achilleas-k
force-pushed
the
fix-var-tmp-in-buildroot
branch
from
e9d67c9 to
c4e6651
Compare
cgwalters
reviewed
Mar 20, 2024
mvo5
force-pushed
the
fix-var-tmp-in-buildroot
branch
2 times, most recently
from
d476b72 to
2eded98
Compare
kingsleyzissou
previously approved these changes
Mar 20, 2024
cgwalters
previously approved these changes
Mar 20, 2024
This is a followup for osbuild#1649 Instead of symlinking /var/tmp to /tmp which may be on a tmpfs this commit puts it on a real filesystem. This should fix: osbuild/bootc-image-builder#285
mvo5
force-pushed
the
fix-var-tmp-in-buildroot
branch
from
2eded98 to
d419330
Compare
Sure. Ping me here if this PR is ready to test. |
kingsleyzissou
approved these changes
Mar 20, 2024
I believe the PR is ready to test |
supakeen
approved these changes
Mar 20, 2024
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup for #1649
Instead of symlinking /var/tmp to /tmp which may be on a tmpfs this commit puts it on a real filesystem.
This should fix:
osbuild/bootc-image-builder#285