ssh keys customization #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
requested changes
Mar 1, 2025
ochosi
approved these changes
Mar 7, 2025
Renames the Additional Users section to just users as it doesn't only apply to adding extra users but also modifying users that already exist. Signed-off-by: Simon de Vlieger <[email protected]>
Mention that Additional Users should be used when adding SSHKeys. Signed-off-by: Simon de Vlieger <[email protected]>
achilleas-k
requested changes
Mar 7, 2025
achilleas-k
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't very clear in the documentation that the "Additional Users" customization can (and will) modify users if they already exist, thus making it the best choice for adding SSH keys to users.
Rewrite the title, mention explicitly under the SSH keys customization that the Users customization should be preferred as it was removed and only exists in
osbuild-composer.See:
sshkeycustomization is ignored image-builder-cli#142