Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: fix inconsistent builds and help running scripts locally #105

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Makefile: fix inconsistent builds and help running scripts locally #105

merged 1 commit into from
Aug 13, 2024

Conversation

schuellerf
Copy link
Contributor

I hope this fixes failing PR tests as there was an inconsistent use of yarn and npm ?!

@schuellerf
Copy link
Contributor Author

making this consistent makes sense I guess, but the real problem seems to be known upstream
cmfcmf/docusaurus-search-local#214 (comment)
which can be avoided like done in this PR - not using yarn at all ;-) )

ochosi
ochosi approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@ochosi ochosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this - I've never liked the inconsistency (but I guess I was too lazy to dig and come up with the proper fix).
<3

@ochosi ochosi merged commit db2b076 into osbuild:main Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ochosi ochosi ochosi approved these changes

@ondrejbudai ondrejbudai Awaiting requested review from ondrejbudai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schuellerf @ochosi