-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return compose request details as part of metadata response #4451
base: main
Are you sure you want to change the base?
Conversation
ca6d2fb
to
df51355
Compare
df51355
to
fd7d358
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I got it correct, this is only for on-prem as it will be empty in the service, right?
To get it consistent we would need to extend image-builder
to also return the request by just getting it from the image-builder DB (json or postgres) in a subsequent PR.
otherwise it LGTM
Two questions aside:
(it's a bit confusing that there is a request in the response, but I hope my comment is somehow readable) |
This is part of https://issues.redhat.com/browse/COMPOSER-2131 (which is also related to cockpit-composer using cloudapi instead of weldr). The request is in the response because I want to reuse the openapi structure instead of reinventing and copying, etc. I don't think size is a consideration, it will be as big as the original request so I don't see any reason to complicate things by trying to hide it. ETA: And yes, it is on-prem only for now, conditional on the artifact directory being used. Using the db is beyond the scope of this PR and can be added later if needed. |
This will allow clients to display more information about a compose, including the image type created, arch and distro, and blueprint to customizations used to create it. Related: RHEL-60120
Related: RHEL-60120
This will help make it easier to write the original compose request json to the same directory tree. Related: RHEL-60120
The original compose request contains useful details that are not preserved when it is converted to a manifest. Things like the distribution, arch, image type, blueprint or customizations are useful when examining builds later. This saves the original request json using the job id and a new directory (ComposeRequest) under the artifacts directory. The original request, if present, is then added to the compose/<id>/metadata response alongside the package list. Related: RHEL-60120
Related: RHEL-60120
fd7d358
to
61fab81
Compare
This pull request includes: