List cloudapi compose jobs #4425
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is just the compose job listing part of #4154 with the output using ComposeStatus instead of just the ids. I'll rewrite the other PR to just do the delete part after this is merged and the questions over there are closed. |
bcl
force-pushed
the
main-just-list-composes
branch
from
b38a0b3 to
ccd9b90
Compare
4 tasks
bcl
force-pushed
the
main-just-list-composes
branch
from
ccd9b90 to
f2a596b
Compare
achilleas-k
reviewed
Nov 26, 2024
There was a problem hiding this comment.
LGTM. Sorry it took long to get around to reviewing and now there are merge conflicts :/
Any reason we can't do the dbjobqueue here too? Would it make the PR too big?
I guess the reasoning is that this is for unifying the weldr API into the cloud API and on-prem the fsjobqueue is used...?
Yeah, it was too large and has some questions about the data structures so I'm trying to do things in smaller steps. |
bcl
force-pushed
the
main-just-list-composes
branch
from
f2a596b to
414fbab
Compare
mvo5
reviewed
Nov 27, 2024
This lists the root job UUIDs (the jobs with no dependants). Currently only implemented by fsjobqueue. The function for dbjobqueue currently returns nil. Related: RHEL-60120
This will be used to list the top level job UUIDs. Related: RHEL-60120
This will make it easier to use the status in responses. Related: RHEL-60120
This returns the status using the same structure as it does for requesting individual statuses for the jobs. Related: RHEL-60120
bcl
force-pushed
the
main-just-list-composes
branch
from
414fbab to
4ef3a62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes: