Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudapi: Add architecture support to the optional Blueprint #4374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cloudapi: Add architecture support to the optional Blueprint #4374

wants to merge 1 commit into from

Conversation

bcl
Copy link
Contributor

@bcl bcl commented Sep 19, 2024

If included it overrides the architecture in the compose image request.

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as
    • submit a PR for the READMEs listed here
    • submit a PR for the osbuild.org website repository if this PR changed any behavior not covered by the automatically updated READMEs

@bcl bcl force-pushed the main-bp-arch branch 2 times, most recently from d98f127 to f33ebc3 Compare October 15, 2024 21:12
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 15, 2024
@bcl bcl removed the Stale label Nov 15, 2024
@bcl bcl force-pushed the main-bp-arch branch 2 times, most recently from 0018048 to 018648f Compare November 15, 2024 18:53
@bcl bcl requested a review from ondrejbudai November 26, 2024 23:28
@bcl
cloudapi: Add architecture support to the optional Blueprint
f683e0f 
The blueprint may have the architecture set. If set it must match the
architecture set by the request. This ensures that clients have
correctly set the architecture and prevents unexpectedly ignoring the
blueprint architecture.

With the WELR API the blueprint architecture would override the host
arch. But with the Cloud API there is no host arch to override so the
request must have the expected architecture set as part of the request.

Related: RHEL-60125
@bcl bcl requested a review from thozza December 17, 2024 18:13
@bcl
Copy link
Contributor Author

bcl commented Dec 17, 2024

Changed this to address @thozza 's comments about arch handling in #4390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejbudai ondrejbudai Awaiting requested review from ondrejbudai

@thozza thozza Awaiting requested review from thozza

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bcl