blueprint: sshkey to users in images blueprint conversion #4363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update osbuild/images to include: - blueprint: remove the sshkey customization (osbuild/images#928). - [RHEL-9] Drop RHSM and RHUI-specific config from Azure and EC2 images (COMPOSER-2308) (osbuild/images#857).
The sshkey customization in osbuild/images has been dropped. In osbuild-composer we maintain it for backwards compatibility, converting each to a user customization, which is a superset of the sshkey.
gce-rhui is now gone from RHEL 9 [1] and the old name simply aliases to gce. gcp-rhui in the cloudapi now resolves to 'gce' in RHEL 9 and 'gce-rhui' in RHEL 8. [1] osbuild/images#857
achilleas-k
force-pushed
the
images/rm/customizations/sshkey
branch
from
973fc8d to
ae2f9fc
Compare
😕 |
There seems to be a caching issue with the linter. It's reporting go dependency replacements when there are none.
thozza
previously approved these changes
Sep 17, 2024
🤔 |
|
It is now called: |
Awesome, thanks for looking it up! |
thozza
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See osbuild/images#928 for reasoning.
go.mod: update osbuild/images to v0.87.0
Update osbuild/images to include:
(blueprint: remove the sshkey customization images#928).
(COMPOSER-2308) ([RHEL-9] Drop RHSM and RHUI-specific config from Azure and EC2 images (COMPOSER-2308) images#857).
blueprint: sshkey to users in images blueprint conversion
The sshkey customization in osbuild/images has been dropped. In
osbuild-composer we maintain it for backwards compatibility, converting
each to a user customization, which is a superset of the sshkey.
cloudapi: update expected image type test for gcp-rhui
gce-rhui is now gone from RHEL 9 [1] and the old name simply aliases to
gce. gcp-rhui in the cloudapi now resolves to 'gce' in RHEL 9 and
'gce-rhui' in RHEL 8.
[1] osbuild/images#857