RHEL 8.5: fixes to image definitions #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OS image tree was being built on the host instead. Signed-off-by: Achilleas Koutsou <[email protected]>
In the main OS pipeline created by osPipeline(), there is often a set of stages that are added after the common ones. The SELinux stage must always be last in the pipeline, so it is added externally by the calling function. Signed-off-by: Achilleas Koutsou <[email protected]>
The previous manifests were generated inside a RHEL VM which means that the selinux context mismatch check didn't run properly (see https://bugzilla.redhat.com/show_bug.cgi?id=1973754). Regenerating them on F34 shows some mismatches for certain image types. Signed-off-by: Achilleas Koutsou <[email protected]>
ondrejbudai
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes up some small (but important) oversights in the image definitions added in #1536.