tool/update_tool: new tool to explore db updates #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May I ask you for a quick example of the output? That would be very valuable to everyone having a look at this PR. :) |
Good idea! I'll record my screen using it with peek and include the gifs inside the PR description and in the README also :) |
achilleas-k
reviewed
Sep 1, 2022
ondrejbudai
requested changes
Sep 2, 2022
There was a problem hiding this comment.
Thanks a lot for the demos, they look really sleek. Some suggestions inline to make the code nicer.
@supakeen May I ask for your opinion on using some kind of templating? I'm still not sure if it improved readability, but I'm just not a fan of formatting text imperatively.
|
@ondrejbudai I'll take a look later this morning, thanks. |
supakeen
reviewed
Sep 5, 2022
supakeen
reviewed
Sep 6, 2022
ondrejbudai
reviewed
Sep 7, 2022
lavocatt
force-pushed
the
dbtool
branch
2 times, most recently
from
b452f9c to
f4f4c20
Compare
ondrejbudai
requested changes
Sep 8, 2022
Db updates are tricky to review. This tools brings some utility functions to try to simplify the process. It gives you access to 3 commands: Ls, Diff and Report List the changed DB entry and know if the manifest or the image info was updated easily. The tool also ignores by default the volatiles UUID so you are not polluted by that during the review process. Diff the changed files, either all of them one after the other or a specific set given by the user. It will open a difftool (vimdiff by default) to diff either the manifest or the image-info (or both if they both changed). Report the change as an ascii table with color codes (by default) or as a github TODO list to be integrated within the github PR.
ondrejbudai
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Db updates are tricky to review. This tools brings some utility
functions to try to simplify the process. It gives you access to 3
commands: Ls, Diff and Report
List the changed DB entry and know if the manifest or the image info was
updated easily. The tool also ignores by default the volatiles UUID so
you are not polluted by that during the review process.
Diff the changed files, either all of them one after the other or a
specific set given by the user. It will open a difftool (vimdiff by
default) to diff either the manifest or the image-info (or both if they
both changed).
Report the change as an ascii table with color codes (by default) or as
a github TODO list to be integrated within the github PR.
report generation
Terminal report
Github report
Listing changed DB entries
Diff all or a list of files