builder: add support for proxying requests to composer #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, I'm finally happy with the test coverage, this is ready to be reviewed now. :) |
gicmo
reviewed
Apr 29, 2022
We need koji-osbuild-builder to be able to connect to composer via a proxy because koji builders in our internal deployment cannot reach api.openshift.com directly. This commit adds a new option `proxy` to the builder plugin config that controls whether a proxy is used to route all requests to composer.
teg
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need koji-osbuild-builder to be able to connect to composer via a proxy
because koji builders in our internal deployment cannot reach
api.openshift.com directly. This commit adds a new option
proxyto thebuilder plugin config that controls whether a proxy is used to route all
requests to composer.
I'm not sure if the integration test that I designed will work, will see. 🤷 I'm open to suggestions.