Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: don't push tests into Fedora #89

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Conversation

ondrejbudai
Copy link
Member

koji-osbuild-tests is dependent on osbuild-composer-tests but this package
is not shipped into Fedora because it provides zero value to users.

Let's do the same for koji-osbuild. koji-osbuild-tests will be built only
in our upstream CI but not built in the official Koji.

@ondrejbudai ondrejbudai requested a review from gicmo March 23, 2022 14:37
@ondrejbudai
Copy link
Member Author

I added a small clean-up on top. My past mistake basically ;)

@ochosi ochosi self-requested a review March 23, 2022 14:41
ochosi
ochosi previously approved these changes Mar 23, 2022
Copy link
Collaborator

@ochosi ochosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the superfluous merge commit it all looks good!

@ondrejbudai
Copy link
Member Author

Fixed, I guess Github cannot rebase?

@ochosi ochosi self-requested a review March 23, 2022 16:16
Copy link
Contributor

@gicmo gicmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this!

koji-osbuild-tests is dependent on osbuild-composer-tests but this package
is not shipped into Fedora because it provides zero value to users.

Let's do the same for koji-osbuild. koji-osbuild-tests will be built only
in our upstream CI but not built in the official Koji.
I introduced this in 0bcac39, we can just
podman-plugins anywhere so let's drop the unneeded conditional dependency.
@gicmo gicmo merged commit 041e99c into osbuild:main Mar 23, 2022
@ondrejbudai ondrejbudai deleted the notests branch March 24, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants