hub: mark baseurl as required in repo schema #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thozza
requested review from
gicmo and
ondrejbudai
and removed request for
gicmo
ondrejbudai
reviewed
Nov 30, 2022
thozza
force-pushed
the
hub-repo-baseurl-schema
branch
from
d0572e6 to
a538c55
Compare
Reformat the code to be easier to read. An empty dict was sometimes passed to `osbuildImage()` as the `priority` argument, because `opts` were already part of `args`. Fix it. Restructure `test_input_validation()` test to allow multiple test cases. Signed-off-by: Tomáš Hozza <[email protected]>
Previously it the `repo` schema didn't mark the `baseurl` property as required, although Cloud API "technically" requires it and the builder code also made assumptions about it being always provided. Note on Cloud API: Cloud API requires that at least one of `baseurl`, `metalink` or `mirrorlist` is specified for a repo. Since the plugin schema specifies only `baseurl` as a property, it is as a result mandatory in order for the Cloud API request to be valid and succeed. Mark `baseurl` property as required in the `repo` schema and add unit test for it. Signed-off-by: Tomáš Hozza <[email protected]>
thozza
force-pushed
the
hub-repo-baseurl-schema
branch
from
a538c55 to
a577f7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it the
reposchema didn't mark thebaseurlproperty asrequired, although Cloud API requires it and the builder code made
assumptions about it being always provided.
Mark
baseurlproperty as required in thereposchema and add unittest for it.