github: remove workflow "Schutzbot comments" #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workflow was added with the plan to make it post a comment on a PR when certain non-required checks failed, without failing the workflows themselves. However, this turns out to require a bit more work than originally anticipated and is probably not worth the effort right now. It might be worth waiting for github to add support for something like this, or we could make a github action for ourselves that abstracts this idea to make it reusable across projects. For now, I'd like to remove the workflow so it doesn't stay in the repo unfinished as clutter. This reverts commit 0fc99d2.
achilleas-k
force-pushed
the
revert-non-requierd-test-comments
branch
from
4d261d4 to
8ccfb2d
Compare
supakeen
approved these changes
Oct 14, 2024
No. It was just an idea I had that I thought would be quick to solve. I'll open a GH issue in the hopes we don't forget this down the line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow was added with the plan to make it post a comment on a PR when certain non-required checks failed, without failing the workflows themselves. However, this turns out to require a bit more work than originally anticipated and is probably not worth the effort right now.
It might be worth waiting for github to add support for something like this, or we could make a github action for ourselves that abstracts this idea to make it reusable across projects.
For now, I'd like to remove the workflow so it doesn't stay in the repo unfinished as clutter.
This reverts commit 0fc99d2.