Pin Go version to 1.21 #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SBOM support for DNF5 is not implemented Is this relevant? |
|
SBOM failures again. |
achilleas-k
reviewed
Oct 16, 2024
Not required to merge. |
lzap
force-pushed
the
go-downgrade
branch
2 times, most recently
from
e7b162b to
2252b89
Compare
|
So I wrote a small utility which allows bumping of dependencies while keeping the Go requirement. It allowed me to bump all dependencies which can be updated and keep Go 1.21. |
|
@achilleas-k ready for re-review |
achilleas-k
approved these changes
Oct 17, 2024
|
Thank you!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library is now dependency in image builder and we agreed on Slack that although it is just two functions from the crypt package, it makes sense to share this code (and from otk), therefore we must do the effort of not upgrading the Go version to latest and greatest but keep the version in check with UBI containers (1.21.x currently).
All dependant bot updates which will fail the build must be closed or kept in a queue until Go can be upgraded few months later.