-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd: add "archName" to gen-manifests mock dnf solver URLs #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the manifest name to the mock depsolve URL output so that we can test for it from inside otk. This will help with issues like https://github.com/osbuild/otk/pull/255/files#r1782953752
mvo5
added a commit
to mvo5/osbuild-otk
that referenced
this pull request
Oct 2, 2024
This follows osbuild/images#968 to include the architecture name in the generated URLs so that we can test for things like https://github.com/osbuild/otk/pull/255/files#r1782953752 This also requires a rebuild of all reference manifests.
This was referenced Oct 2, 2024
mvo5
added a commit
to mvo5/osbuild-otk
that referenced
this pull request
Oct 2, 2024
This commit re-generates all reference osbuild manifests with the new `archName` that is part of the mocked depsolve URLs from osbuild/images#968
supakeen
approved these changes
Oct 2, 2024
mvo5
added a commit
to mvo5/osbuild-otk
that referenced
this pull request
Oct 2, 2024
This follows osbuild/images#968 to include the architecture name in the generated URLs so that we can test for things like https://github.com/osbuild/otk/pull/255/files#r1782953752 This also requires a rebuild of all reference manifests.
mvo5
added a commit
to mvo5/osbuild-otk
that referenced
this pull request
Oct 2, 2024
This commit re-generates all reference osbuild manifests with the new `archName` that is part of the mocked depsolve URLs from osbuild/images#968
mvo5
added a commit
to mvo5/osbuild-otk
that referenced
this pull request
Oct 2, 2024
This commit re-generates all reference osbuild manifests with the new `archName` that is part of the mocked depsolve URLs from osbuild/images#968
github-merge-queue bot
pushed a commit
to osbuild/otk
that referenced
this pull request
Oct 2, 2024
This follows osbuild/images#968 to include the architecture name in the generated URLs so that we can test for things like https://github.com/osbuild/otk/pull/255/files#r1782953752 This also requires a rebuild of all reference manifests.
github-merge-queue bot
pushed a commit
to osbuild/otk
that referenced
this pull request
Oct 2, 2024
This commit re-generates all reference osbuild manifests with the new `archName` that is part of the mocked depsolve URLs from osbuild/images#968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the manifest name to the mock depsolve URL output so that we can test for it from inside otk. This will help with issues like https://github.com/osbuild/otk/pull/255/files#r1782953752
This will require a re-generate of all otk reference manifests.