Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: New otk external: otk-make-ostree-source #960

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

achilleas-k
Copy link
Member

@achilleas-k achilleas-k commented Sep 30, 2024

A new command for otk that creates the org.osbuild.ostree source object based on the resolved ostree commit data generated from the osbuild-resolve-ostree-commit command.

@achilleas-k achilleas-k force-pushed the otk-make-ostree-source branch from 20ce03d to 991e65c Compare October 7, 2024 11:54
@achilleas-k achilleas-k marked this pull request as ready for review October 7, 2024 11:55
@achilleas-k
Copy link
Member Author

Rebased on #922 to include renamed cmds.

@achilleas-k achilleas-k requested review from mvo5 and supakeen October 7, 2024 11:56
A new command for otk that creates the org.osbuild.ostree source object
based on the resolved ostree commit data generated from the
osbuild-resolve-ostree-commit command.
Move the struct that defines the output of the otk-resolve-ostree-commit
command to an internal package and reuse it as the input for the
otk-make-ostree-source command.
@achilleas-k achilleas-k force-pushed the otk-make-ostree-source branch from 991e65c to 1dde478 Compare October 7, 2024 16:25
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks fine!

@mvo5 mvo5 added this pull request to the merge queue Oct 11, 2024
Merged via the queue into osbuild:main with commit 302881b Oct 11, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants