Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: build edge-commit with parent #956

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

achilleas-k
Copy link
Member

We never had a test configuration where an ostree commit is built as child of another one. Let's add a simple configuration where an ostree commit is built from an existing one.

The parent commit is the base image with no customizations (empty) and the child commit adds a user (edge-ostree-pull-user).

We never had a test configuration where an ostree commit is built as
child of another one.  Let's add a simple configuration where an ostree
commit is built from an existing one.

The parent commit is the base image with no customizations (empty) and
the child commit adds a user (edge-ostree-pull-user).
@achilleas-k achilleas-k requested a review from lzap September 27, 2024 14:11
@lzap
Copy link
Contributor

lzap commented Oct 7, 2024

Sure, thanks. Tho I am not exactly sure what this change does - is there some kind of generator you must run or something? Tests are failing, is this relevant?

I would like to have full end to end test, osrepo is just a plain directory served over HTTP so I could work on publishing some "example" repo that could be used by a test in the osbuild mirror perhaps?

@achilleas-k
Copy link
Member Author

Sure, thanks. Tho I am not exactly sure what this change does - is there some kind of generator you must run or something?

Test setup and configuration is described here: https://github.com/osbuild/images/tree/main/test

Tests are failing, is this relevant?

We have some non-required reverse dependency tests with osbuild-composer. They mostly serve as a reminder that updating osbuild/images in osbuild-composer will need work (it's not a clean update). It would be great if they were warnings instead of failures, but that's not something GitHub offers. Perhaps we can have it post a message on a PR when it causes the change (from working to non-working), so we don't have a list of PRs that are constantly red.

I would like to have full end to end test, osrepo is just a plain directory served over HTTP so I could work on publishing some "example" repo that could be used by a test in the osbuild mirror perhaps?

That would be a good idea. For every other type of source we have static resources: rpmrepo for RPM repository snapshots, and small toy containers for pulling containers in builds. An static (or regularly/dynamically updated) ostree commit repo would be great. The problem has always been that there was never a good way to host an ostree repository and especially one that you can push into until Pulp gained support, which is quite recent. With traditional rpm-ostree being replaced by bootc-based images, it might be tricky to justify the effort to set something like this up, but if you feel like doing it, by all means!

@croissanne croissanne added this pull request to the merge queue Oct 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 8, 2024
@supakeen
Copy link
Member

supakeen commented Oct 8, 2024

t would be great if they were warnings instead of failures, but that's not something GitHub offers. Perhaps we can have it post a message on a PR when it causes the change (from working to non-working), so we don't have a list of PRs that are constantly red.

This would be really nice; I always go back into my PRs to figure out why they're red and then see it's rawhide or integration :)

@achilleas-k achilleas-k added this pull request to the merge queue Oct 9, 2024
Merged via the queue into osbuild:main with commit c5e8a62 Oct 9, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants