pkg/dnfjson/dnfjson_test.go: fix crashing on failing test #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
reviewed
Sep 27, 2024
schuellerf
force-pushed
the
fix-crash-on-failing-test
branch
from
283cce9 to
56db964
Compare
The test are currently failing on fedora 41 but that's no reason to really segfault just due to a failed test. Also fixes the obviously smilar problem with res.SBOM
schuellerf
force-pushed
the
fix-crash-on-failing-test
branch
from
56db964 to
85a2497
Compare
supakeen
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are currently failing on fedora 41 (SBOM implementation missing for DNF5)
but that's no reason to really segfault just due to a failed test.