otk-gen-partition-table: support EFI system on DOS partitions #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This constant is used for the DOS partition table EFI system partition. So far it was just a hardcoded string but this will be used by the otk partition externals too so let's extract it into a constant.
The existing code to create EFI system partitions was making assumptions about running on a GPT partition. This is no longer true with osbuild/otk#199 so this commit fixes the code to create a valid ESP system partition on a DOS partition table.
supakeen
approved these changes
Sep 16, 2024
achilleas-k
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code to create EFI system partitions was making
assumptions about running on a GPT partition. This is no longer
true with osbuild/otk#199 so this commit
fixes the code to create a valid ESP system partition on a DOS
partition table.