osbuild: add support for LVM to GenBootupdDevicesMounts()
#876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
reviewed
Aug 26, 2024
There was a problem hiding this comment.
Can we break this down into multiple commits? At least 2, but possibly 3 (if tests are done separately):
- Update of options in
lv2_lv_device.go(with tests) - Changes to
bootupd_stage.gofor supporting LVM.
It's not really important, but might make it easier to follow the history.
ondrejbudai
reviewed
Aug 26, 2024
Add support for the new `vg_partnum` parameter for the `org.osbuild.lvm2.lv` devices. This allows to mount the logical volume from a single underlying loop device which is required for `bootc install to-filesystem/bootupd`. See osbuild/osbuild#1867
This is required for `bootc-image-builder` to support LVM. It works by using the new `vg_partition` option to the `org.osbuild.lvm2.lv` device and use it when generating the bootc/bootupd mounts. This way all mounts can come from the same underlying loop device and bootc/bootupd can install the bootloader there. See also osbuild/osbuild#1867
mvo5
force-pushed
the
osbuild-bootupdate-add-lvm-vg_partnum
branch
from
c699a19 to
2f4478b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for
bootc-image-builderto support LVM. It works by using the newvg_partitionoption to theorg.osbuild.lvm2.lvdevice and use it when generating the bootc/bootupd mounts.This way all mounts can come from the same underlying loop device and bootc/bootupd can install the bootloader there. See also osbuild/osbuild#1867