[RHEL-10] Add gce and image-installer image types (COMPOSER-2193)
#869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop 'dhcp-client' package from the pkg set, because it is no longer available on RHEL-10. NM did not default to it already since RHEL-9 anyway. Use el9 GCP repositories for now, because there is no el10 version. For now, add cloud-init as a replacement for GCP guest tools. Signed-off-by: Tomáš Hozza <[email protected]>
Signed-off-by: Tomáš Hozza <[email protected]>
The stage schema expects array of objects as the property items. Signed-off-by: Tomáš Hozza <[email protected]>
thozza
force-pushed
the
el10-img-types
branch
2 times, most recently
from
7afd819 to
ea1933c
Compare
thozza
requested review from
ondrejbudai,
mvo5,
achilleas-k and
kingsleyzissou
It is based on RHEL-9, with the package set adjusted for RHEL-10. Signed-off-by: Tomáš Hozza <[email protected]>
The issues that was blocking the signature verification for Google packages on RHEL-9 is now resolved. Signed-off-by: Tomáš Hozza <[email protected]>
Unify the way of checking the custom mountpoins in the test_distro with other distros. And also return the same error message as they would. Signed-off-by: Tomáš Hozza <[email protected]>
Signed-off-by: Tomáš Hozza <[email protected]>
This is needed to pick osbuild/osbuild#1860 and make tests pass on c10s / el10. Signed-off-by: Tomáš Hozza <[email protected]>
kingsleyzissou
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA.
The image types are based on RHEL-9, with their package set adjusted for RHEL-10.
The GCE image temporarily uses cloud-init, because there are no GCP guest tools builds for el10 / c10s yet.
On top of that I reported a new issue for GPG keys used by Google, which makes them unusable on el10 / c10s - https://issuetracker.google.com/issues/360905189. And while I was at it and was testing things, I reverted the disabled GPG check for Google repos on el9, because the issue that was blocking it there has been resolved.
Cross-tested in composer in osbuild/osbuild-composer#4314. At the time of edit, all newly added tests passed, except for image-installer on c10s, which got stuck. I rescheduled it, but el10 test passed.