Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schutzfile: update osbuild dependency #725

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

achilleas-k
Copy link
Member

@achilleas-k achilleas-k commented Jun 3, 2024

Some strange failures started happening last week in our CI. The ostree containers that we use to build ostree-based images appear to be randomly failing to start, or return 403 Forbidden when queried. This makes our CI pipeline flaky which is blocking any PR from being merged through the merge queue (see for example the failures here https://gitlab.com/redhat/services/products/image-builder/ci/images/-/pipelines/1314481981).

I suspect this might be related to PR #716, which changes the CI configurations to all run on Fedora 40. In that PR, all ostree containers were rebuilt on F40 and now all subsequent runs (that don't need to update the image) use these new containers. I'm hoping the issue is related to our Fedora 40 runners being quite old (pre GA), and some already-solved bug is causing this.

I need to look into this further and figure out if (and why) this is happening, but in the meantime, let's try to unblock PRs by rebuilding everything on Fedora 39 again.

This PR updates the osbuild commit ID, which will trigger a rebuild of all image types.

Update to commit ID for current main.
For ostree-based systems we need a default ref that depends on  the
product name (iot or edge).  So far, if it wasn't set, we would get an
error (`product` would be undefined).  Let's explicitly raise the error.
If a distro ever gets added that includes an ostree build and is not one
of the three existing ones, we should know to update this.
We use dot-separated version numbers for RHEL now so let's split on dot
to get the major.
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. Hopefully this stabilizes things.

@achilleas-k achilleas-k enabled auto-merge June 3, 2024 17:46
Copy link

@elkoniu elkoniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achilleas-k achilleas-k added this pull request to the merge queue Jun 3, 2024
Merged via the queue into osbuild:main with commit 8551348 Jun 3, 2024
17 checks passed
@achilleas-k achilleas-k deleted the bump-osbuild branch June 3, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants