-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnfjson: allow (optional) field solver
in the dnfjson output
#723
Conversation
Looks good, other than the linting complaints :) |
4835c79
to
e95f344
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Technically we can merge this before the osbuild PR and it wouldn't be a problem, but let's do it in proper order.
Then we could also run the unit tests in dnfjson_test.go
against both solvers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, pylint is apparently befuddled by having a raise in an else before using a variable.
Made #729 to ignore the pylint error |
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
With the new "dnf5" solver is seems useful to allow the dnfjson code return what solver was actually used in the transaction. This commit allows an (optional) "solver" field in the json that is returned from the dnfjson helper. It does not do more yet but we should (probably) make it avaialble for the higher layers too so that it can be e.g. logged. See also osbuild/osbuild#1776 Co-authored-by: Achilleas Koutsou <[email protected]>
bbe94b8
to
a8f9e7d
Compare
This commit includes the used sovler in the dnfjson reply. This is mostly information (e.g. in service logs) but also useful in tests to ensure that the expected solver was really run. Note that this needs osbuild/images#723 first.
This commit includes the used sovler in the dnfjson reply. This is mostly information (e.g. in service logs) but also useful in tests to ensure that the expected solver was really run. Note that this needs osbuild/images#723 first.
This commit includes the used sovler in the dnfjson reply. This is mostly information (e.g. in service logs) but also useful in tests to ensure that the expected solver was really run. Note that this needs osbuild/images#723 first.
With the new "dnf5" solver is seems useful to allow the dnfjson code return what solver was actually used in the transaction.
This commit allows an (optional) "solver" field in the json that is returned from the dnfjson helper. It does not do more yet but we should (probably) make it avaialble for the higher layers too so that it can be e.g. logged.
See also osbuild/osbuild#1776