pkg/osbuild: Simplify GenMkfsStages arguments #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior this commit, the implementation was slightly confusing: GenMkfsStages accepted a generic device as the source of the underlying disk image. However, the function could only operate on a loopback, otherwise it panicked. Moreover, the function didn't actually use the given device: it just used the filename from the given loopback device. The actual device for generated stages is created in getDevices. Let's simplify this: The function now accepts just the filename, since this is actually the only thing that it needs. Also added tests. The unhappy path still relies on a panic, but this is a huge rabbit hole that I don't want to explore at this point.
mvo5
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior this commit, the implementation was slightly confusing: GenMkfsStages accepted a generic device as the source of the underlying disk image. However, the function could only operate on a loopback, otherwise it panicked. Moreover, the function didn't actually use the given device: it just used the filename from the given loopback device. The actual device for generated stages is created in getDevices.
Let's simplify this: The function now accepts just the filename, since this is actually the only thing that it needs.
Also added tests. The unhappy path still relies on a panic, but this is a huge rabbit hole that I don't want to explore at this point.