Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/osbuild: clean up genMountsForBootupd #685

Merged
merged 1 commit into from
May 14, 2024

Conversation

ondrejbudai
Copy link
Member

Instead of the if statement, I switched to switch (pun absolutely intended). Also, I fixed the error message, previously it always printed type , because mnt is set to nil, if ok == false.

Instead of the if statement, I switched to switch (pun absolutely
intended). Also, I fixed the error message, previously it always
printed type <nil>, because mnt is set to nil, if ok == false.
@ondrejbudai ondrejbudai requested a review from mvo5 May 14, 2024 09:00
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I like switches so I approve of the switch to switch (but let's not switch again).

@achilleas-k achilleas-k added this pull request to the merge queue May 14, 2024
Merged via the queue into osbuild:main with commit 8373145 May 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants