cmd: add helper for seed generation #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure that manifests get random(ish) and stable UUIDs we set the rng seed arg based on the filename. This should fix the issue discovered in osbuild/manifest-db#124 that duplicated UUIDs for xfs/btrfs can trigger random(ish) and hard to diagnose errors. This is the same as osbuild/osbuild-composer#4124 hopefully for the right place this time.
mvo5
force-pushed
the
consolidate-some-more
branch
from
decd9d4 to
4df0926
Compare
achilleas-k
previously requested changes
May 14, 2024
Simplify the previous commit so that SeedArgFor() takes strings
for the image type and distribution instead of the `namer`
interface. This makes the code a little bit easier to follow but
now the `distro.Distro` and `distro.ImageType` cannot be directly
passed into the helper anymore so it's a tradeoff.
Ideally it would just take `distro.{Distro,ImageType}` but for
that we would need an easy way to construct fake objects of
these types in our tests which there (currently) is not (AFAICT).
So settle with this approach as a compromise for now.
mvo5
force-pushed
the
consolidate-some-more
branch
from
e53c3c1 to
34b152d
Compare
Thank you! Silly me, fixed now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure that manifests get random(ish) and stable UUIDs we set the rng seed arg based on the filename.
This should fix the issue discovered in
osbuild/manifest-db#124
that duplicated UUIDs for xfs/btrfs can trigger random(ish) and hard to diagnose errors.
This is the same as
osbuild/osbuild-composer#4124 hopefully for the right place this time.