Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distro: add initial support for el10/c10s (COMPOSER-2185) #516

Merged
merged 9 commits into from
Mar 14, 2024

Conversation

thozza
Copy link
Member

@thozza thozza commented Mar 13, 2024

To unblock c10s development, add a quick and dirty version of RHEL-10/c10s.

Fix #501

@thozza thozza marked this pull request as draft March 13, 2024 14:54
@thozza
Copy link
Member Author

thozza commented Mar 13, 2024

repo needs to be added, but blocked on osbuild/rpmrepo#94

To unblock c10s development, add a quick and dirty version of
RHEL-10/c10s.

Fix osbuild#501

Signed-off-by: Tomáš Hozza <[email protected]>
@achilleas-k
Copy link
Member

achilleas-k commented Mar 14, 2024

To get the ball rolling for RHEL 10 and CentOS Straem 10, for now we will only support the following image types on EL10 because of package availability:

  • ami
  • oci (oracle)
  • openstack
  • ova
  • qcow2
  • tar
  • vhd
  • vmdk
  • wsl

Other image types will be added in follow-ups while packages required for those images become available (or we discover/decide they are not needed).

@achilleas-k achilleas-k marked this pull request as ready for review March 14, 2024 12:29
ondrejbudai
ondrejbudai previously approved these changes Mar 14, 2024
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@achilleas-k
Copy link
Member

Updated image type list: vhd added
Also insights-client is added now. On my local machine, it was failing to depsolve because it couldn't find what provides /usr/libexec/platform-python due to a bug combined with a change in libdnf: https://issues.redhat.com/browse/RHEL-28665

This shouldn't be an issue on our test runners for now.

This enum value is used for package selection across major distros when
instantiating manifests.
This is an osbuild dependency that is needed in the buildroot for some
features.  For EL10, osbuild uses the stdlib toml module.
Compare the releaseVersion instead of the osVersion against "10" instead
of for package selection to make the rule also work for CentOS Stream 10.
Temporarily separate the image type addition in the rhel9 package to
only add a small subset of image types to EL10 (RHEL 10.0 and CentOS
Stream 10).

For a start, we will only support the following image types on EL10
because of package availability:
- ami
- oci (oracle)
- openstack
- ova
- qcow2
- tar
- vhd
- vmdk
- wsl

This big conditional separation should be removed when most image types
become available in EL10.
Content in these repos is currently unsigned.
Missing package: scap-security-guide
ondrejbudai
ondrejbudai previously approved these changes Mar 14, 2024
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The image config specifies a key in the OS tree that should be imported
during the build, but this isn't yet available on RHEL 10, so let's skip
it for now.
@ondrejbudai ondrejbudai added this pull request to the merge queue Mar 14, 2024
Merged via the queue into osbuild:main with commit 2f18fe6 Mar 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a distro entry for RHEL 10
4 participants