Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repo: Fedora 41 repositories #456

Closed
wants to merge 1 commit into from
Closed

repo: Fedora 41 repositories #456

wants to merge 1 commit into from

Conversation

supakeen
Copy link
Member

@supakeen supakeen commented Feb 21, 2024 •
edited
Loading

Fedora 41 repositories

ondrejbudai
ondrejbudai previously approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

thozza
thozza previously approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thozza thozza enabled auto-merge February 21, 2024 09:26
@supakeen
Copy link
Member Author

supakeen commented Feb 22, 2024 •
edited
Loading

It seems there are missing packages in Fedora 41: podman-plugins which is required by a few image types (iot-container, iot-commit) and defined in the iot-commit package set.

The subpackage podman-plugins was removed in this commit for podman 5.0: https://src.fedoraproject.org/rpms/podman/c/2ab1bb3d2d6b3e9df18449494a081fcbe8044d4c?branch=rawhide

I'll tag @paulwhalen and @nullr0ute on this, we can disable podman-plugins conditionally for Fedora > 40 though it seems 5.0 is also in 40 itself?

@supakeen supakeen dismissed stale reviews from thozza and ondrejbudai February 22, 2024 09:47

Some issues were found in the package sets.

@supakeen
Copy link
Member Author

I've dismissed the reviews on this PR until the above can be resolved.

@pcdubs
Copy link

pcdubs commented Feb 22, 2024

It seems there are missing packages in Fedora 41: podman-plugins which is required by a few image types (iot-container, iot-commit) and defined in the iot-commit package set.

The subpackage podman-plugins was removed in this commit for podman 5.0: https://src.fedoraproject.org/rpms/podman/c/2ab1bb3d2d6b3e9df18449494a081fcbe8044d4c?branch=rawhide

I'll tag @paulwhalen and @nullr0ute on this, we can disable podman-plugins conditionally for Fedora > 40 though it seems 5.0 is also in 40 itself?

Right, podman-5.0 is included in F40, so the change should be made there as well.

We also had to drop passwd as its provided by shadow-utils in F40+

@supakeen
Copy link
Member Author

It seems there are missing packages in Fedora 41: podman-plugins which is required by a few image types (iot-container, iot-commit) and defined in the iot-commit package set.
The subpackage podman-plugins was removed in this commit for podman 5.0: https://src.fedoraproject.org/rpms/podman/c/2ab1bb3d2d6b3e9df18449494a081fcbe8044d4c?branch=rawhide
I'll tag @paulwhalen and @nullr0ute on this, we can disable podman-plugins conditionally for Fedora > 40 though it seems 5.0 is also in 40 itself?

Right, podman-5.0 is included in F40, so the change should be made there as well.

We also had to drop passwd as its provided by shadow-utils in F40+

Right, do you or @nullr0ute want to write a PR to drop those packages from the package sets for Fedora >= 40 or shall I do it for you?

@mcattamoredhat mcattamoredhat mentioned this pull request Feb 27, 2024
Open
@pcdubs
Copy link

pcdubs commented Feb 27, 2024

It seems there are missing packages in Fedora 41: podman-plugins which is required by a few image types (iot-container, iot-commit) and defined in the iot-commit package set.
The subpackage podman-plugins was removed in this commit for podman 5.0: https://src.fedoraproject.org/rpms/podman/c/2ab1bb3d2d6b3e9df18449494a081fcbe8044d4c?branch=rawhide
I'll tag @paulwhalen and @nullr0ute on this, we can disable podman-plugins conditionally for Fedora > 40 though it seems 5.0 is also in 40 itself?

Right, podman-5.0 is included in F40, so the change should be made there as well.
We also had to drop passwd as its provided by shadow-utils in F40+

Right, do you or @nullr0ute want to write a PR to drop those packages from the package sets for Fedora >= 40 or shall I do it for you?

I can do the PR, sorry the delayed response.

@supakeen
Copy link
Member Author

Thank you @paulwhalen.

@supakeen supakeen force-pushed the fedora-41-repositories branch from 85f47b4 to de1651d Compare February 29, 2024 07:00
@supakeen
Copy link
Member Author

Rebased now that #480 has landed in main which should turn this PR green.

@supakeen
Copy link
Member Author

supakeen commented Mar 1, 2024

@ondrejbudai @achilleas-k it seems the CI for the iot-bootable-container is an actual failure but I haven't been able to figure out why yet. Does either of you have an idea?

@supakeen supakeen force-pushed the fedora-41-repositories branch from de1651d to bcef4c4 Compare March 4, 2024 16:53
@achilleas-k achilleas-k self-assigned this Mar 4, 2024
@supakeen
Copy link
Member Author

supakeen commented Mar 5, 2024 •
edited
Loading

Not booting is a known issue with shim for aarch64, see: https://bugzilla.redhat.com/show_bug.cgi?id=2259264

We probably want to make rawhide CI failable as rawhide is expected to break every now and then :)

@supakeen supakeen force-pushed the fedora-41-repositories branch from bcef4c4 to 35aceb1 Compare March 11, 2024 10:08
@supakeen supakeen force-pushed the fedora-41-repositories branch from 35aceb1 to 0a3b574 Compare March 19, 2024 08:15
achilleas-k
achilleas-k previously approved these changes Mar 19, 2024
View reviewed changes
@supakeen supakeen force-pushed the fedora-41-repositories branch from 0a3b574 to dd974d0 Compare March 19, 2024 23:17
@achilleas-k
Copy link
Member

https://issues.redhat.com/browse/RHEL-29559 is happening in F41 now too.

@supakeen supakeen force-pushed the fedora-41-repositories branch 3 times, most recently from 45cb713 to bdb0c44 Compare March 26, 2024 22:44
@supakeen supakeen force-pushed the fedora-41-repositories branch from bdb0c44 to 68fca4f Compare March 27, 2024 11:08
@achilleas-k achilleas-k force-pushed the fedora-41-repositories branch 2 times, most recently from 6a8ebef to 186e1b0 Compare April 5, 2024 13:46
@achilleas-k achilleas-k force-pushed the fedora-41-repositories branch from 186e1b0 to 48a64aa Compare April 8, 2024 13:22
@achilleas-k
Copy link
Member

One issue I realise now with F41 being allowed to fail is that the failing builds will never have an image/manifest in the CI cache, which will cause builds for the failed builds to run every time. This will slow down CI a lot for PRs that don't affect any image definitions.

@supakeen supakeen force-pushed the fedora-41-repositories branch from 48a64aa to a9be754 Compare April 12, 2024 08:43
@supakeen supakeen closed this Apr 12, 2024
auto-merge was automatically disabled April 12, 2024 08:50

Pull request was closed

@achilleas-k
Copy link
Member

If we want to bring F41 repos and builds and avoid the issue with rpm-ostree we could temporarily disable the ostree-based image types in F41 only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thozza thozza thozza left review comments

@achilleas-k achilleas-k achilleas-k left review comments

@ondrejbudai ondrejbudai ondrejbudai left review comments

Assignees

@achilleas-k achilleas-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@supakeen @pcdubs @achilleas-k @ondrejbudai @thozza