osbuild: remove unused ContainersInputs (note the *s*)
#320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the unused ContainersInputs and moves the `isStageInputs()` function to `ContainersInput` (not the missing *s* at the end). The type/function looks like an oversight, I did a `git grep` and `grep -r` accross our repos and AFAICT the type is not used.
ondrejbudai
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while working on adding support for build roots from container inputs. It looks like an oversight but I wanted to open it as it's own PR so that it does not get lost in the noise of the followup :)
Draft for now as I want to see the testsuite finish first (locally everything seems fine and AFACIT nothing imports this type but maybe I'm missing something?).
This commit removes the unused ContainersInputs and moves the
isStageInputs()function toContainersInput(not the missing s at the end).The type/function looks like an oversight/leftover, I did a
git grepandgrep -raccross our repos and AFAICT the type is not used.