Remove dnf-json #313
Merged
Remove dnf-json #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the dnf-json script from the repository. Instead, the library will depend on osbuild-depsolve-dnf, an osbuild subpackage, for depsolving.
The Makefile is outdated and not very useful in its current form. Leaving it there is a bit misleading and can make people think there's something wrong if they try to use it.
This is duplicated from osbuild-composer and isn't used in any tests or other tooling.
Install osbuild-depsolve-dnf to run unit tests. Remove the linter check for dnf-json.
Add findDepsolveDnf() to the dnfjson package and call it when initialising the solver. This used to be a helper function in some of the cmds and would look for dnf-json in the current directory for running it from sources then fall back to the installed locations. Now that it's no longer part of the repository, it only searches for the installed locations, `/usr/libexec` for the official Fedora, CentOS, and RHEL paths, and `/usr/lib/osbuild` for other distros that might not user `/usr/libexec`.
achilleas-k
force-pushed
the
rm/dnf-json
branch
from
4d864bc to
a7ce2ab
Compare
supakeen
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the dnf-json script from the repository. Instead, the library will depend on osbuild-depsolve-dnf, an osbuild subpackage, for depsolving.
Add
findDepsolveDnf()to thednfjsonpackage and call it when initialising the solver. This used to be a helper function in some of the cmds and would look for dnf-json in the current directory for running it from sources then fall back to the installed locations. Now that it's no longer part of the repository, it only searches for the installed locations,/usr/libexecfor the official Fedora, CentOS, and RHEL paths, and/usr/lib/osbuildfor other distros that might not use/usr/libexec.