test: Add PR number to build info and share test caches #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When filtering builds for a CI run and the commit ID is printed for an image that was already built, also print the PR number (and URL) if it's set.
The same way we print a list of image configurations built in a specific CI run, let's also print a list of configurations built in the same PR (identified by the CI_COMMIT_BRANCH). Again, this makes it a bit more convenient to check which images were rebuilt in a PR, but we should eventually use this information to inform PR authors and reviewers of changes in image definitions.
These have already been set in the repository config.
Set the cache root to be under the working directory. This is used for rpmmd and the build info downloaded from S3. By putting it in the working directory, we can share the cache with subsequent pipelines to speed up subsequent runs.
The test cache holds the RPM metadata for depsolving (rpmmd) and a local copy of the build info from s3. Caching it and sharing it between jobs should speed up config generation.
achilleas-k
force-pushed
the
test/build-info/pr-number
branch
from
2728ea3 to
048ecfb
Compare
ochosi
approved these changes
Oct 20, 2023
|
Looking at the numbers of the jobs, it doesn't seem to have had much of an effect. Maybe there's a smarter way to do it, but I think it doesn't hurt to keep it. |
|
I want to add a starter job that pulls in all the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two small changes to the test pipelines:
check-build-coveragejobs. Eventually, we can use this information to add messages to the PR so it's easier to track what is being built by each pipeline run.