Support arbitrary custom mountpoints #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thozza
force-pushed
the
custom-mountpoints
branch
from
a44f926 to
319aded
Compare
Add a simple unit test for the current definition of `MountpointPolicies` to capture various scenarios of what is currently allowed and what is not. This will be helpful in the next steps when the policy gets relaxed and reworked. Delete distro unit-tests which were responsible for checking that some specific mountpoints are not allowed by the mountpoint policy. The newly added policy unit test tests the same thing, but on a single place. Signed-off-by: Tomáš Hozza <[email protected]>
Any mountpoints under `/usr` are not supported by systemd fstab generator in initram before the switch-root, so we don't allow them. Until now, a user could create a custom mountpoint in e.g. `/usr/lib`, which would make the system unbootable. Signed-off-by: Tomáš Hozza <[email protected]>
Before relaxing the mountpoints policy, let's first disallow paths which can't or should not be backed by a separate partition. This has no effect on the current mountpoint policy, because all of these paths are already disallowed. Signed-off-by: Tomáš Hozza <[email protected]>
Any path, which is not explicitly disallowed, can now be specified as a separate mountpoint. Signed-off-by: Tomáš Hozza <[email protected]>
thozza
force-pushed
the
custom-mountpoints
branch
from
319aded to
8425d31
Compare
achilleas-k
reviewed
Oct 20, 2023
Not that I know of. I was just not sure if I didn't forget to fix some tests. 😇 But in general, this should be sufficient for this repo. |
achilleas-k
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://issues.redhat.com/browse/COMPOSER-2030