[RFC] packagesets: add basic imagetype yaml to merge pkgSets (non-symetric) #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a basic imagetype yaml to support merging
of package sets This is a useful feature so that we can e.g.
avoid duplicating the `cloud_base` or `anaconda` package sets.
It works by adding a new toplevel "image_types" in the
package_sets.yaml.
It allows us to write:
```yaml
image_types:
qcow2:
package_sets:
- cloud_base_pkgset
- qcow2_pkgset
package_sets:
cloud_base_pkgset:
include: [foo]
exclude: [bar]
qcow2_pkgset:
include: ["qemu-guest-agent"]
```
The downside of this approach is that it is nice to read but not
symetrical, i.e. one cannot just include the pkgset verbatim in
an `image_type`, it always needs to be defined inside the
"package_sets" key. It also uses the same "package_sets" name
for two different things which is also slightly not nice.
mvo5
changed the title
|
Stylistically I prefer #1295, it also seems like that one would more easily map on people who have knowledge of YAML as opposed to this one. |
mvo5
changed the title
|
Closing this in favor of #1298 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[draft as this is one possible way of doing it, all fedora package_sets.yaml needs converting, not a huge fan because it is not symmetrical but it is very simple. maybe different naming would make it feel less asymetric. alternative version of https://github.com/https://github.com//pull/1294 and https://github.com//pull/1295]
This commit adds a basic imagetype yaml to support merging of package sets This is a useful feature so that we can e.g. avoid duplicating the
cloud_baseoranacondapackage sets.It works by adding a new toplevel "image_types" in the package_sets.yaml.
It allows us to write:
The downside of this approach is that it is nice to read but not symetrical, i.e. one cannot just include the pkgset verbatim in an
image_type, it always needs to be defined inside the "package_sets" key. It also uses the same "package_sets" name for two different things which is also slightly not nice.