many: move machine id first boot to image config #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thozza
reviewed
Feb 25, 2025
supakeen
force-pushed
the
machine-id-image-config
branch
from
585d2be to
6a1cee1
Compare
achilleas-k
previously approved these changes
Feb 27, 2025
supakeen
force-pushed
the
machine-id-image-config
branch
2 times, most recently
from
9bb5af2 to
e379461
Compare
achilleas-k
previously approved these changes
Feb 27, 2025
supakeen
force-pushed
the
machine-id-image-config
branch
from
e379461 to
1e06711
Compare
|
Several of the IoT images are failing due to: I've addressed this in a new commit (I hope). And also addressed @achilleas-k's comment on the comment(s) since I was force pushing anyhow. |
achilleas-k
previously approved these changes
Feb 27, 2025
supakeen
force-pushed
the
machine-id-image-config
branch
2 times, most recently
from
35bf37e to
5d6086c
Compare
|
This seems to finally be OK but I think it rebuilt images that I didn't expect to be rebuilt? |
supakeen
force-pushed
the
machine-id-image-config
branch
2 times, most recently
from
840bf01 to
38610da
Compare
|
Cool, all good now :) |
mvo5
reviewed
Mar 4, 2025
Signed-off-by: Simon de Vlieger <[email protected]>
This moves the machine id handling from specific to Fedora to the image config. Signed-off-by: Simon de Vlieger <[email protected]>
Don't turn off the regeneration of the machine id for the iot image types, it breaks in rpm-ostree. Signed-off-by: Simon de Vlieger <[email protected]>
supakeen
force-pushed
the
machine-id-image-config
branch
from
38610da to
dac855f
Compare
|
Force pushed to resolve conflicts. |
achilleas-k
approved these changes
Mar 4, 2025
thozza
approved these changes
Mar 5, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the machine id handling from specific to Fedora to the image config.
Had a chat with @achilleas-k and @thozza today who pointed out that they'd prefer this to live in the image config. Is this the right approach?