fedora: image type names follow variants

[supakeen]

Fedora consists of many variants. Historically we haven't really based our own definitions on anything. Let's introduce variant name prefixes to all Fedora image types to indicate what variant they are based on.

The next commit will then make these variants similar to (or equal to) the Fedora variants as they are supposed to be.

We keep the old image type names around as aliases since changing them is a breaking change. We should however consider deprecating them and emitting a warning for some time.

[supakeen]

I'll assume this needs discussion and followups :)

[supakeen]

The config map commit needs more changes as the image types are now different between various distros they need to be split out; which means duplicating the files since those are the paths.

[achilleas-k]

which means duplicating the files since those are the paths.

Not necessary. The image type names don't need to all be valid for each distro, so for example you can have

diff --git a/test/config-map.json b/test/config-map.json
index e8add2b20..4d548d7b0 100644
--- a/test/config-map.json
+++ b/test/config-map.json
@@ -135,6 +135,7 @@
       "gce",
       "gce-rhui",
       "image-installer",
+      "minimal-installer",
       "iot-bootable-container",
       "iot-container",
       "live-installer",
@@ -264,7 +265,8 @@
       "x86_64"
     ],
     "image-types": [
-      "image-installer"
+      "image-installer",
+      "minimal-installer"
     ]
   },
   "./configs/unattended-iso.json": {

and it will work. Just add the new names in the same lists where the old names were.

[supakeen]

and it will work. Just add the new names in the same lists where the old names were.

Ah that's good, I'll do that :)

[schutzbot]

This PR changes the images API or behaviour causing integration failures with osbuild-composer. The next update of the images dependency in osbuild-composer will need work to adapt to these changes.

This is simply a notice. It will not block this PR from being merged.

[supakeen]

This PR changes the images API or behaviour causing integration failures with osbuild-composer. The next update of the images dependency in osbuild-composer will need work to adapt to these changes.

This is simply a notice. It will not block this PR from being merged.

Names will need to be updated in osbuild-composer after this merges as well. It can probably request the old names but it reports back the new names.

[supakeen]

@achilleas-k I might be missing something but the Schutzbot CI fails on:

❌ 2 distro/arch/image combinations have no builds in the cache
   1: fedora-41/x86_64/server-wsl
   2: fedora-40/x86_64/server-wsl

I think I have server-wsl listed under ./configs/empty.json?