-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] osbuild: define the minimum osbuild version and enforce it #1194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this makes sense, I like it.
One thing I would change though is to probably put the minimum version in a text file and compile it in with go:embed
, just for visibility and to make it easier to work with in some automated way. For example, if we want to read it during some testing, or if someone is browsing the repo to find it, it would be a lot easier to be able to point to something like res/osbuild-min-version
. We could even link to it from the README or some docs without needing to point to specific lines in code.
Great idea! |
b77f689
to
2a30c5b
Compare
Define a new variable storing the minimum osbuild version supported by the module and an exported function to get it. The actual version is stored in a text file under `data/dependencies/` directory and embedded at compile time. Enforce the minimum version when executing osbuild. This has the potential to prevent surprises when using older osbuild with `images` implementation that relies on changes in a newer version of osbuild. This will allow dependent projects to extract the minimum version and check if their packaging requirements are up to date with the version of `images` that they depend on. This will enable adding a composite GH action that can be used by other projects depending on `osbuild/images` to check that their SPEC file depends at least on the specified osbuild version. Signed-off-by: Tomáš Hozza <[email protected]>
2a30c5b
to
352be86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably call the file osbuild-minimum-version
in case we want to also check other stuff later on but we can do that when we want to check other stuff later on.
I initially used the filename that you've suggested, but then decided to use only the dependency name. The reason is that I can then iterate over the files in a custom GH action and take the filename as the name of the dependency and its content as the minimum version. |
Define a new variable storing the minimum osbuild version supported
by the module and an exported function to get it. The actual version is
stored in a text file under
data/dependencies/
directory and embeddedat compile time. Enforce the minimum version when executing osbuild.
This has the potential to prevent surprises when using older osbuild
with
images
implementation that relies on changes in a newer versionof osbuild.
This will allow dependent projects to extract the minimum version and
check if their packaging requirements are up to date with the version of
images
that they depend on.This will enable adding a composite GH action that can be used by other
projects depending on
osbuild/images
to check that their SPEC filedepends at least on the specified osbuild version.