Add ability to use plain squashfs as the iso rootfs #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ondrejbudai
reviewed
Dec 13, 2024
cgwalters
previously approved these changes
Dec 13, 2024
|
Moving this back to draft for the moment, I need to move RootfsType into manifest instead of image to make it easier to add Erofs support later (it will need to switch out the Squashfs stage in anaconda_installer_iso_tree.go, I'll do that Monday. |
Fedora 41 and later, and RHEL 10 use plain squashfs instead of compressing an ext4 filesystem.
This test assumed the image's static list of pipeline names must match the manifest, but it really only needs to check the ones with rpm or ostree metadata. To support the ability to have images with different pipelines (eg. squashfs only vs. ext4+squashfs rootfs iso creation) this changes the test to make sure the pipelines in the static list are in the manifest, and in the order specified. But the two lists do not need to match exactly.
This pipeline is no longer used on Fedora 41 and later. They use a plain squashfs install.img instead of wrapping an ext4 filesystem with squashfs. But it may be present in older versions, the test in distro_test.go has been adjusted to ensure that all pipelines named are present and in the correct order without requiring that this is an exact list of pipeline names.
Make sure that the rootfs-image pipeline is present in ext4 images and not present in squashfs only images.
|
Ok, this should be ready now. There followup to this later that will add erofs support instead of squashfs, but that's for later. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.