Add test for invalid hash algorithm for package checksum #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
commented
Aug 11, 2023
There was a problem hiding this comment.
@achilleas-k I wasn't expecting the test to pass in its current form. Can you review ?
achilleas-k
force-pushed
the
more_tests_for_hashing_algorithms
branch
from
ce2e5f6 to
7e8f607
Compare
|
I added validation to sources for the checksums. I moved the validation into the sources instead of the inputs to mirror what we actually do in osbuild. The checksums are defined per-source, meaning different source types have different checksum requirements. So I did the same here and added a checksum validation for curl sources that represent rpm packages. I also kept the old checksum validator in the file inputs. |
thozza
reviewed
Aug 22, 2023
The inline and skopeo sources have constructors for the source itself (New...Source()) and the items (New...Item()) as well as an AddItem() method. These are convenient and make source creation consistent and easier to validate. Add the same functions for curl and ostree sources. For the curl source, the method is called AddPackage() because technically the source supports downloading any type of file.
Check that the package checksum is valid when creating a CurlSourceItem of that type. The regex matches the one in the osbuild source schema.
Run the item's validate() method immediately after creating it in the constructor function.
Use the new helper functions to generate all the sources in GenSources().
Co-Authored-By: Achilleas Koutsou <[email protected]>
Check the error value returned from curl.AddPackage() in GenSources() and pass it up to the Serialize() function where it's called.
achilleas-k
force-pushed
the
more_tests_for_hashing_algorithms
branch
from
7e8f607 to
04a4a49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.