blueprint: fix DiskCustomization.MinSize with existing pattern #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
previously approved these changes
Nov 22, 2024
The disk customizations min-size setting is not accepting strings or strings with units. This commit adds a failing test that will validate the fix.
This commit fixes the issue that minsize cannot be a string by using the existing pattern. See osbuild#1049 for alternative ideas.
mvo5
force-pushed
the
disk/followups2
branch
from
9ee9d1e to
d2a5d1a
Compare
mvo5
commented
Nov 22, 2024
| @@ -18,6 +18,27 @@ type DiskCustomization struct { | |||
| Partitions []PartitionCustomization `json:"partitions,omitempty" toml:"partitions,omitempty"` | |||
| } | |||
|
|
|||
| func (dc *DiskCustomization) UnmarshalJSON(data []byte) error { | |||
There was a problem hiding this comment.
meh, this lacks the toml unmarshaler :(
There was a problem hiding this comment.
Also needs some error tests
There was a problem hiding this comment.
We probably can close this in favor of #1057 which archives this with less code (but some boilerplate).
mvo5
added a commit
to mvo5/images
that referenced
this pull request
Nov 22, 2024
This commit fixes the issue that minsize cannot be a string by using the existing pattern. See osbuild#1055 for the alternative approach.
|
Moving to draft as this can most likely get closed in favor of #1057 |
|
Closing in favor of #1057 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
This commit fixes the issue that minsize cannot be a string by using the existing pattern. See #1055 for the alternative approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue that minsize cannot be a string
by using the existing pattern.
See #1049 for alternative
ideas.
The disk customizations min-size setting is not accepting strings
or strings with units. This commit adds a failing test that will
validate the fix.
[this was found as part of the work in bib, https://github.com/osbuild/bootc-image-builder/pull/721]