ostree: extract httpClientForRef from resolveRef
#1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is great, can you add a test for client cert/key as well as CA certs? |
mvo5
force-pushed
the
ostree-proxyparser-test
branch
2 times, most recently
from
34559bc to
1a42113
Compare
Added |
mvo5
commented
Nov 20, 2024
This commit extracts a `httpClientForRef` helper from the `resolveRef()` function. This helps with readability and testability. It also adds a test for the proxy setting, CA and MTLS settings.
mvo5
force-pushed
the
ostree-proxyparser-test
branch
from
1a42113 to
c4d00f2
Compare
supakeen
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extracts a
httpClientForRefhelper from theresolveRef()function. This helps with readability and testability. It also adds
a test for the proxy setting.
Not ideal as the test knows a bit too much about the implementation details but OTOH realtively straightfoward to add.
[build on top of https://github.com//pull/1050]