Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor distros so we don't have to add a new one whenever it gets branched #104

Closed
wants to merge 7 commits into from
Closed

Refactor distros so we don't have to add a new one whenever it gets branched #104

wants to merge 7 commits into from

Conversation

ondrejbudai
Copy link
Member

@ondrejbudai ondrejbudai commented Aug 10, 2023 •
edited
Loading

This is very WIP, I want to have feedback from the test suite firstly.

@ondrejbudai ondrejbudai added the WIP+test Work in progress but run Gitlab CI. label Aug 10, 2023
@ondrejbudai ondrejbudai force-pushed the distro-refactor branch 2 times, most recently from 96358d5 to 553ddb1 Compare August 10, 2023 15:36
@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 11, 2023
@achilleas-k achilleas-k removed the Stale label Sep 12, 2023
@thozza
Copy link
Member

thozza commented Oct 9, 2023

@ondrejbudai this PR looks very promising. Do you plan to finish it any time soon? I'm asking, because the lack of support for 9.4 / 8.10 is currently blocking the latest osbuild-composer releases in RHEL gating. Thus I created #195 as a quick fix. But if this PR would be finished earlier, I'd be happy to close mine.

@ondrejbudai
Copy link
Member Author

I hope to finish it! :) Will try to take a look at this in the upcoming days.

@thozza thozza self-assigned this Nov 3, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 4, 2023
@thozza
Copy link
Member

thozza commented Dec 4, 2023

Let's close this one. I'm working on this change, but want to took a bit different, although very similar approach which is heavily based on Ondrej's work. I don't want to push to his branch and will open a new PR instead.

@thozza thozza closed this Dec 4, 2023
@thozza thozza mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thozza thozza

Labels
Stale WIP+test Work in progress but run Gitlab CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ondrejbudai @thozza @achilleas-k